Guard JavaCoordinator JAR scan against symlink cycles#67693
Open
jason810496 wants to merge 2 commits into
Open
Guard JavaCoordinator JAR scan against symlink cycles#67693jason810496 wants to merge 2 commits into
jason810496 wants to merge 2 commits into
Conversation
jason810496
added
the
AIP-108: Coordinator
github-project-automation
Bot
moved this to Backlog
in AIP-108: Java Task SDK and the Language Coordinator Layer
jason810496
moved this from Backlog
to In review
in AIP-108: Java Task SDK and the Language Coordinator Layer
kaxil
approved these changes
May 29, 2026
uranusjr
reviewed
May 29, 2026
uranusjr
reviewed
May 29, 2026
Drop the per-directory list() materialization in the JAR scan in favor of a lazy iterdir() walk, keeping a small helper so an unreadable directory is skipped instead of aborting the scan. Pass the Path straight to the debug log rather than stringifying it, matching the other log calls.
jason810496
force-pushed
the
refactor/coordinator/harden-java-coordinator-discovery
branch
from
1415782 to
ff4c02b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Caught by claude during self-review in #67161, we should guard symlink loop or a hardlinked directory under
jars_root. Otherwise, the_find_jarswill enter infinite recursion loop and OOM.Was generative AI tooling used to co-author this PR?