Skip to content

Speed up Dag serialization by skipping redundant asset roundtrip #67702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shahar1 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Speed up Dag serialization by skipping redundant asset roundtrip #67702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions airflow-core/src/airflow/serialization/serialized_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,14 +918,16 @@ def detect_task_dependencies(task: SdkOperator) -> list[DagDependency]:

for obj in task.outlets or []:
if isinstance(obj, (Asset, SerializedAsset)):
serialized_asset = ensure_serialized_asset(obj)
# The unique key only needs ``name``/``uri``, and asset encode/decode
# copies both verbatim, so build the key directly and skip the full
# ensure_serialized_asset() encode→decode roundtrip on every outlet.
deps.append(
DagDependency(
source=task.dag_id,
target="asset",
label=obj.name,
dependency_type="asset",
dependency_id=SerializedAssetUniqueKey.from_asset(serialized_asset).to_str(),
dependency_id=SerializedAssetUniqueKey(name=obj.name, uri=obj.uri).to_str(),
)
)
elif isinstance(obj, (AssetAlias, SerializedAssetAlias)):
Expand Down
Loading