[v3-2-test] Fix per-index evaluation of ONE_FAILED in mapped task groups (#67684)#67704
Merged
Merged
Conversation
…ups (#67684) A task using a "fast triggered" trigger rule (ONE_FAILED, ONE_SUCCESS, ONE_DONE) inside a mapped task group was evaluated against every expanded instance of its upstream, instead of the upstream instance sharing its own map index. As a result a single failed (or succeeded) upstream instance wrongly triggered the rule for every expanded instance of the task — e.g. a mapped ONE_FAILED reporting task ran for all map indexes when only one upstream had failed. The broad "depend on every upstream instance" behavior is only needed for the not-yet-expanded summary task instance (map_index < 0), so a fast trigger rule does not prematurely skip the task before the mapped task group expands (the case fixed in #34023). Restrict that special case to the summary instance; expanded instances now use the normal per-map-index upstream resolution. (cherry picked from commit 862b647) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> closes: #50210
1 task
vatsrahul1001
approved these changes
May 29, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
May 29, 2026
…ups (#67684) (#67704) A task using a "fast triggered" trigger rule (ONE_FAILED, ONE_SUCCESS, ONE_DONE) inside a mapped task group was evaluated against every expanded instance of its upstream, instead of the upstream instance sharing its own map index. As a result a single failed (or succeeded) upstream instance wrongly triggered the rule for every expanded instance of the task — e.g. a mapped ONE_FAILED reporting task ran for all map indexes when only one upstream had failed. The broad "depend on every upstream instance" behavior is only needed for the not-yet-expanded summary task instance (map_index < 0), so a fast trigger rule does not prematurely skip the task before the mapped task group expands (the case fixed in #34023). Restrict that special case to the summary instance; expanded instances now use the normal per-map-index upstream resolution. (cherry picked from commit 862b647) closes: #50210 Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A task using a "fast triggered" trigger rule (ONE_FAILED, ONE_SUCCESS,
ONE_DONE) inside a mapped task group was evaluated against every expanded
instance of its upstream, instead of the upstream instance sharing its own
map index. As a result a single failed (or succeeded) upstream instance
wrongly triggered the rule for every expanded instance of the task — e.g. a
mapped ONE_FAILED reporting task ran for all map indexes when only one
upstream had failed.
The broad "depend on every upstream instance" behavior is only needed for
the not-yet-expanded summary task instance (map_index < 0), so a fast
trigger rule does not prematurely skip the task before the mapped task group
expands (the case fixed in #34023). Restrict that special case to the
summary instance; expanded instances now use the normal per-map-index
upstream resolution.
(cherry picked from commit 862b647)
Co-authored-by: Shahar Epstein 60007259+shahar1@users.noreply.github.com
closes: #50210