Skip to content

Chart: Select NetworkPolicy log-access component by Airflow version#67817

Merged
potiuk merged 1 commit into
apache:chart/v1-2x-testfrom
potiuk:fix-networkpolicy-log-component-by-version
May 31, 2026
Merged

Chart: Select NetworkPolicy log-access component by Airflow version#67817
potiuk merged 1 commit into
apache:chart/v1-2x-testfrom
potiuk:fix-networkpolicy-log-component-by-version

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented May 31, 2026

Follow-up to #67805 (backport of #65754), addressing review feedback: the
1.2x chart line supports both Airflow 2.11 and Airflow 3, so the
NetworkPolicy log-ingress selector must depend on the Airflow version rather
than being replaced outright.

In Airflow 2.11 task logs are served by the webserver; in Airflow 3 they
are served by the api-server. #65754 unconditionally changed the
scheduler / triggerer / worker NetworkPolicy log-ingress from selectors to
component: api-server, which would break task log access on Airflow 2.11
deployments (where no api-server component exists).

This selects the component based on .Values.airflowVersion:

component: {{ if semverCompare ">=3.0.0" .Values.airflowVersion }}api-server{{ else }}webserver{{ end }}

— mirroring how the chart already chooses between the webserver and
api-server components elsewhere (deployments, services, network policies).
The render tests for all three components now cover both Airflow 2.11
(webserver) and Airflow 3 (api-server).

This targets chart/v1-2x-test and should land before the 1.22.0rc1 cut so
the regression never ships.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4.8)

Generated-by: Claude Code (Opus 4.8) following the guidelines

The 1.2x chart line supports both Airflow 2.11 (logs served by the webserver) and Airflow 3 (logs served by the api-server). apache#65754 unconditionally changed the scheduler/triggerer/worker NetworkPolicy log-ingress selectors to api-server, which would break task log access on Airflow 2.11 deployments. Choose the component based on .Values.airflowVersion via semverCompare (>=3.0.0 -> api-server, else webserver), matching how the chart already selects webserver vs api-server elsewhere. Tests now cover both Airflow versions.
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I assume this has never worked before with the old chart!

@potiuk potiuk merged commit 908cfe0 into apache:chart/v1-2x-test May 31, 2026
31 checks passed
@potiuk potiuk deleted the fix-networkpolicy-log-component-by-version branch May 31, 2026 21:19
potiuk added a commit that referenced this pull request May 31, 2026
…67819)

With #67817 the NetworkPolicy log-access fix (#65754) is version-aware and works for both Airflow 2.11 and 3, so reword the 1.22.0 changelog entry (and matching ArtifactHub annotation) from 'Airflow 3' to 'Airflow 2 and 3'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants