Chart: Select NetworkPolicy log-access component by Airflow version#67817
Merged
potiuk merged 1 commit intoMay 31, 2026
Merged
Conversation
The 1.2x chart line supports both Airflow 2.11 (logs served by the webserver) and Airflow 3 (logs served by the api-server). apache#65754 unconditionally changed the scheduler/triggerer/worker NetworkPolicy log-ingress selectors to api-server, which would break task log access on Airflow 2.11 deployments. Choose the component based on .Values.airflowVersion via semverCompare (>=3.0.0 -> api-server, else webserver), matching how the chart already selects webserver vs api-server elsewhere. Tests now cover both Airflow versions.
jscheffl
approved these changes
May 31, 2026
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Good catch! I assume this has never worked before with the old chart!
1 task
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #67805 (backport of #65754), addressing review feedback: the
1.2x chart line supports both Airflow 2.11 and Airflow 3, so the
NetworkPolicy log-ingress selector must depend on the Airflow version rather
than being replaced outright.
In Airflow 2.11 task logs are served by the webserver; in Airflow 3 they
are served by the api-server. #65754 unconditionally changed the
scheduler / triggerer / worker NetworkPolicy log-ingress
fromselectors tocomponent: api-server, which would break task log access on Airflow 2.11deployments (where no
api-servercomponent exists).This selects the component based on
.Values.airflowVersion:— mirroring how the chart already chooses between the
webserverandapi-servercomponents elsewhere (deployments, services, network policies).The render tests for all three components now cover both Airflow 2.11
(
webserver) and Airflow 3 (api-server).This targets
chart/v1-2x-testand should land before the 1.22.0rc1 cut sothe regression never ships.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines