Add default parameter to task and asset state get() accessors#67842
Merged
amoghrajesh merged 4 commits intoJun 3, 2026
Conversation
jroachgolf84
approved these changes
Jun 1, 2026
Collaborator
jroachgolf84
left a comment
There was a problem hiding this comment.
LGTM! Excellent addition :)
vincbeck
approved these changes
Jun 1, 2026
kaxil
reviewed
Jun 1, 2026
(cherry picked from commit 57454d118a913b9feabbab58ae673843c4239690)
kaxil
approved these changes
Jun 2, 2026
Contributor
Author
|
The failures are unrelated, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
closes: #67841
What?
TaskStoreAccessor.get()andAssetStoreAccessor.get()returnedNonewhen a key did not exist, which made callers to use None checks ororbased fallbacks likestate.get("watermark") or "2026-01-01". This is not the best authoring experience and does not follow the standard Pythondict.get(key, default)pattern.Current behaviour
state.get("watermark")returns None if the key has never been set. Callers must writestate.get("watermark") or "fallback", which is both verbose for no benefit.Proposed change
get()onTaskStoreAccessorandAssetStoreAccessor, and theAssetStoreAccessorsshorthand accessor. The default isNone. Example usage:Noneis not a valid state valueThe example dag
example_asset_store.pyis updated to use the new form.{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.