[v3-2-test] Validate GCSToSambaOperator destination path stays within destination_path (#67857)#67913
Closed
github-actions[bot] wants to merge 1 commit into
Closed
[v3-2-test] Validate GCSToSambaOperator destination path stays within destination_path (#67857)#67913github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
… destination_path (#67857) GCS object names are read from the source bucket and may contain ".." segments. GCSToSambaOperator._resolve_destination_path joined the object name onto the configured destination_path without normalisation, so a crafted object name could resolve an SMB write target outside the intended directory. Normalise the resolved path and refuse to write when it falls outside destination_path. (cherry picked from commit bc1df02) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Generated-by: Claude Opus 4.8 (1M context)
4 tasks
Contributor
|
This is provider PR does not need cherry pick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCS object names are read from the source bucket and may contain ".."
segments. GCSToSambaOperator._resolve_destination_path joined the object
name onto the configured destination_path without normalisation, so a
crafted object name could resolve an SMB write target outside the intended
directory. Normalise the resolved path and refuse to write when it falls
outside destination_path.
(cherry picked from commit bc1df02)
Co-authored-by: Jarek Potiuk jarek@potiuk.com
Generated-by: Claude Opus 4.8 (1M context)