Skip to content

Fix example_asset_store consumer crash and test comment typos#67922

Merged
kaxil merged 1 commit into
apache:mainfrom
astronomer:fix-asset-store-rename-fallout
Jun 2, 2026
Merged

Fix example_asset_store consumer crash and test comment typos#67922
kaxil merged 1 commit into
apache:mainfrom
astronomer:fix-asset-store-rename-fallout

Conversation

@kaxil
Copy link
Copy Markdown
Member

@kaxil kaxil commented Jun 2, 2026

Fallout from the task_state->task_store rename (#67833):

  • example_asset_store consume() fell back to the string "{}" when the asset had no last_run_summary yet, then called .get() on it, raising AttributeError. Fall back to an empty dict so .get() works.
  • A eager find-replace turned "statement(s)" into "Storement(s)" in two comments in test_context.py. Restored the original words.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Fallout from the task_state->task_store rename (apache#67833):

- example_asset_store consume() fell back to the string "{}" when the
  asset had no last_run_summary yet, then called .get() on it, raising
  AttributeError. Fall back to an empty dict so .get() works.
- A blind find-replace turned "statement(s)" into "Storement(s)" in two
  comments in test_context.py. Restored the original words.
@kaxil kaxil merged commit 88dd697 into apache:main Jun 2, 2026
94 of 95 checks passed
@kaxil kaxil deleted the fix-asset-store-rename-fallout branch June 2, 2026 22:00
Copy link
Copy Markdown
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants