Upload task logs even when final state update fails#67935
Open
manipatnam wants to merge 3 commits into
Open
Conversation
When a task subprocess exits, the supervisor updates the task's terminal state and then uploads the remote logs. If the state update raised (e.g. a transient API error), log upload was skipped entirely — yet a failed state update is exactly when the logs are most needed for debugging. Run the log upload in a `finally` block so it always happens, while the original state-update exception still propagates to the caller.
potiuk
added
the
ready for maintainer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a task subprocess exits, the supervisor first updates the task's terminal state and then uploads the remote logs. If the state update raised (for example, a transient API error talking to the API server), the log upload was skipped entirely — yet a failed state update is exactly when the logs are most needed for debugging.
This moves the
_upload_logs()call into afinallyblock so logs are always uploaded, while the original state-update exception still propagates to the caller._upload_logs()already swallows and logs its own errors, so thefinallycannot mask the state-update failure.Added a test (
test_logs_uploaded_even_when_state_update_fails) covering: state update raises → logs still uploaded → original exception propagates.(task-sdk change; ships in airflow-core.)
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines