Call prot_p() in FTPSHook so the FTPS data channel is protected #67946
Merged
Conversation
potiuk
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some FTPS servers are configured to require a protected data channel and reject any data transfer that is not preceded by "PROT P". Against such a server, the current
FTPSHook/FTPSFileTransmitOperatorpath fails with:ftplib.error_perm: 550 SSL/TLS required on the data channel.After this change, the same operator interoperates correctly with both permissive and strict FTPS servers.
This PR adds the missing
self.conn.prot_p()call after login, matching the standardftplib.FTP_TLSusage documented in the Python stdlib:Was generative AI tooling used to co-author this PR?