[v3-2-test] Document Python 3.10 client RC reproducibility + verify helper (#67898)#67953
Merged
Conversation
…elper (#67898) * Document Python 3.10 client RC reproducibility and add verify helper Documents that the Python client reproducible build must run under Python 3.10 (the trigger_dag_run_post_body.py AST re-emit is interpreter-version sensitive), and adds dev/verify_python_client_rc.sh — a headless contributor smoke test that boots airflow standalone inside breeze and runs test_python_client.py against the live API. * Fail fast when building Python client under non-default Python prepare-python-client must run under DEFAULT_PYTHON_MAJOR_MINOR_VERSION (3.10): the client generator re-emits trigger_dag_run_post_body.py with ast.unparse, which uses the running interpreter's grammar, so any other Python yields a non-reproducible client. The existing guard only ran after full code generation (which itself can fail or emit nothing under the wrong Python), so the command never failed cleanly. Hoist the check to the start of the command so it exits immediately with actionable guidance, and document that the command now refuses to run under any other Python. (cherry picked from commit e50c226) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
1 task
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk,
shahar1,
vatsrahul1001 and
vincbeck
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents that the Python client reproducible build must run under Python 3.10
(the trigger_dag_run_post_body.py AST re-emit is interpreter-version sensitive),
and adds dev/verify_python_client_rc.sh — a headless contributor smoke test that
boots airflow standalone inside breeze and runs test_python_client.py against
the live API.
prepare-python-client must run under DEFAULT_PYTHON_MAJOR_MINOR_VERSION
(3.10): the client generator re-emits trigger_dag_run_post_body.py with
ast.unparse, which uses the running interpreter's grammar, so any other
Python yields a non-reproducible client. The existing guard only ran
after full code generation (which itself can fail or emit nothing under
the wrong Python), so the command never failed cleanly.
Hoist the check to the start of the command so it exits immediately with
actionable guidance, and document that the command now refuses to run
under any other Python.
(cherry picked from commit e50c226)
Co-authored-by: Jarek Potiuk jarek@potiuk.com