Support tpl rendering in volumes, volumeMounts and pgbouncer.configSecretName#67958
Open
thejoeejoee wants to merge 2 commits into
Open
Support tpl rendering in volumes, volumeMounts and pgbouncer.configSecretName#67958thejoeejoee wants to merge 2 commits into
thejoeejoee wants to merge 2 commits into
Conversation
…cretName Wrap .Values.volumes and .Values.volumeMounts in tpl() across all chart templates and the pod-template-file, allowing users to use Go template expressions in global volume definitions. Also wrap pgbouncer.configSecretName in tpl() with a nil-guard in the pgbouncer_config_secret helper. closes: apache#67951
thejoeejoee
requested review from
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
jscheffl
reviewed
Jun 3, 2026
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Can you please add some documentation as well, not only code?
Also in the values.yaml and values-schema it would be very good to mark the properties which are now templated (like e.g. in https://github.com/apache/airflow/blob/main/chart/values.yaml#L648)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap
.Values.volumesand.Values.volumeMountsintpl()across all chart templates and the pod-template-file, allowing users to use Go template expressions in global volume definitions.Also wrap
pgbouncer.configSecretNameintpl()with a nil-guard in thepgbouncer_config_secrethelper.closes: #67951
Was generative AI tooling used to co-author this PR?
Generated-by: Opencode (Opus 4.6) following the guidelines