[v3-2-test] Fix flaky e2e remote-logging tests: create LocalStack buckets via loopback (#67976)#67981
Merged
Merged
Conversation
…kets via loopback (#67976) The remote-logging and XCom object-storage e2e tests intermittently failed with NoSuchBucket because the LocalStack init hook never created the buckets. init-aws.sh runs inside the localstack container, but connected to the docker compose service name (http://localstack:4566), which is not reliably connectable from within the container at the READY-hook stage. When it failed, 'aws s3 mb' exited non-zero and the buckets were never created, so worker PutObject calls returned NoSuchBucket. Connect over loopback (http://localhost:4566) instead, and add a short readiness wait with 'set -euo pipefail' so a transient gateway delay cannot silently leave the buckets uncreated. (cherry picked from commit 23adbde) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
1 task
bugraoz93
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote-logging and XCom object-storage e2e tests intermittently failed
with NoSuchBucket because the LocalStack init hook never created the buckets.
init-aws.sh runs inside the localstack container, but connected to the docker
compose service name (http://localstack:4566), which is not reliably
connectable from within the container at the READY-hook stage. When it failed,
'aws s3 mb' exited non-zero and the buckets were never created, so worker
PutObject calls returned NoSuchBucket.
Connect over loopback (http://localhost:4566) instead, and add a short
readiness wait with 'set -euo pipefail' so a transient gateway delay cannot
silently leave the buckets uncreated.
(cherry picked from commit 23adbde)
Co-authored-by: Jarek Potiuk jarek@potiuk.com