Fix IDC domain S3 path resolution#67987
Draft
qaziashikin wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: Scoping notebook output reads to project S3 prefix
The hook reads notebook outputs from a fixed bucket-root key:
That works for IAM domains (the bucket has no per-project prefix) but fails for IDC domains, whose project role only grants S3 access under the project's own scope:
The kernel that writes the file is moving to use the project's full
ProjectS3Pathas the prefix, matching the role's allowed key space. Mirror that on the read side here:get_project_s3_pathnow returns(bucket, prefix).prefixis the path component of thes3BucketPathprovisioned resource.get_notebook_outputsprependsprefixwhen constructing the output key, so reads target the same path the kernel writes to.Testing
Tested by invoking the DAGs both IAM and IDC domains.
Was generative AI tooling used to co-author this PR?