Require generated request body flags in airflowctl#68000
Open
ibobgunardi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated airflowctl commands expand request-body models into CLI flags, but required Pydantic fields were still optional to argparse. That let the command reach request-body validation before telling the user what was missing.
This passes
field_info.is_required()through when building those flags, so commands likeconnections createreport missing required fields as normal CLI arguments.closes: #57721
Tests:
.venv\Scripts\python.exe -m pytest airflow-ctl\tests\airflow_ctl\ctl\test_cli_config.py -q --confcutdir=airflow-ctl\tests\airflow_ctl\ctl.venv\Scripts\python.exe -m py_compile airflow-ctl\src\airflowctl\ctl\cli_config.py airflow-ctl\tests\airflow_ctl\ctl\test_cli_config.pyWas generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.