fix: align param controls in trigger DAG flexible form (#67852)#68003
Open
bujjibabukatta wants to merge 1 commit into
Open
fix: align param controls in trigger DAG flexible form (#67852)#68003bujjibabukatta wants to merge 1 commit into
bujjibabukatta wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #67852
In the AF3 Trigger DAG modal, boolean toggle switches and other param controls were not vertically aligned with their labels in the horizontal two-column layout. When labels differed in length, controls appeared at inconsistent heights, making the form harder to scan.
Changes
FieldRow.tsxcolumnGap={4}toField.Rootto add breathing room between the label and control columnsjustifyContent="center"to the controlStackso thatSwitchtoggles (and other controls) vertically center within their column cellNo changes to
FieldBool.tsxor any other field component — the misalignment was purely a layout issue inFieldRow.Testing
Tested with a DAG that has multiple boolean params of varying label lengths. Toggles now share a consistent right-aligned column, matching the AF2 trigger form behaviour described in the issue.
Related