Reduce redundant Dag team lookups in authorization checks#68020
Merged
vincbeck merged 1 commit intoJun 5, 2026
Conversation
e8a6b1b to
d7b301e
Compare
vincbeck
approved these changes
Jun 4, 2026
Contributor
|
CI is failing |
henry3260
approved these changes
Jun 4, 2026
Contributor
henry3260
left a comment
There was a problem hiding this comment.
looks good!
test_bulk_delete_query_count_scales_linearly_with_task_count still asserts
the old exact counts, we should update it
d7b301e to
7a919b3
Compare
Contributor
Author
You're right, sorry. Once it was approved I moved it out of draft, but an approval isn't the same as a green CI, and I should have confirmed that first. The failure wasn't in the tests this change adds. Caching the Dag team lookup shaves one query off the bulk task-instance delete path, which tripped a pre-existing query-count regression guard there. That's the cross-area interaction I didn't catch. It's now fixed and pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #61485
requires_access_dagresolves a Dag's owning team viaDagModel.get_team_nameon every call — twice per grid endpoint (TASK_INSTANCE+RUN) and on every auto-refresh poll.This caches the lookup with a short per-process TTL.
Other large costs discussed in #61485 have already been addressed by separate PRs. I left the detailed breakdown in the issue comment, and this PR covers the remaining redundant Dag team lookup.
Impact
Team-ownership DB queries per grid page load:
Also included
[core] team_name_cache_ttl(default30s).Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.