Detect Spark driver completion by container state when tracking via k8s API#68048
Open
karenbraganz wants to merge 2 commits into
Open
Detect Spark driver completion by container state when tracking via k8s API#68048karenbraganz wants to merge 2 commits into
karenbraganz wants to merge 2 commits into
Conversation
Collaborator
Author
|
I still need to test this out and write unit tests. I was also thinking of moving the code to find the pod and container names out of the while loop that is run during every poll. I think it should be enough to get the names once instead of redundantly querying the API to get the names each time. Does this make sense to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
track_driver_via_k8s_api, detect driver completion by container status rather than pod phase #67934This PR tracks Spark job completion by container state instead of pod phase when
track_driver_via_k8s_api=True. Sometimes the pod continues to run even after the driver container completes due to other sidecar containers. This PR makes driver completion detection more accurate by examining the container itself.