Mask all connection extra and variable values in API audit log#68049
Open
potiuk wants to merge 1 commit into
Open
Mask all connection extra and variable values in API audit log#68049potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
potiuk
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
The API audit-log writer recorded connection `extra` values and variable values selectively, by matching the field's key name against the secrets masker's sensitive-key list — so values stored under other key names were written to Log.extra verbatim. Record only which `extra` fields were present (masking every value) and mask the variable value unconditionally, so the audit log captures that a connection or variable changed without persisting the values themselves.
potiuk
force-pushed
the
mask-audit-log-connection-extra-and-variable-values
branch
from
d670359 to
01ecbce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API audit-log writer (
action_logging) recorded connectionextravalues and variable values selectively, based on whether each field's key
name matched the secrets masker's sensitive-key list. Values stored under
other key names were written to the audit log verbatim.
This records only which
extrafields were present (masking every value)and masks the variable value unconditionally — the audit log captures that
a connection or variable changed, not its contents.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.8 (1M context) following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions