Fix CI/CD running full matrix on push to release branches (v3-X-test)#68057
Merged
Conversation
On push to release branches like v3-2-test, the full test matrix was unconditionally running because _should_run_all_tests_and_versions() didn't distinguish between push events to main vs release branches. Release branch pushes should only run selective tests (based on changed files), while canaries (SCHEDULE) and manual triggers (WORKFLOW_DISPATCH) still get the full matrix. Added branch-aware gating: push to release branches now returns False from _should_run_all_tests_and_versions() unless other conditions (pyproject.toml changes, etc.) require full tests. Includes test case validating the behavior across different event types and branches. Fixes: apache#68052 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
shahar1
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-2-test
shahar1
removed
the
backport-to-v3-2-test
Contributor
Author
|
I first created the backport and then ported to current PR: |
jscheffl
approved these changes
Jun 5, 2026
bugraoz93
approved these changes
Jun 5, 2026
vatsrahul1001
approved these changes
Jun 5, 2026
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On push to release branches like v3-2-test, the full test matrix was unconditionally running because
_should_run_all_tests_and_versions()didn't distinguish between push events to main vs release branches.Release branch pushes should only run selective tests (based on changed files), while canaries (SCHEDULE) and manual triggers (WORKFLOW_DISPATCH) still get the full matrix.
Added branch-aware gating: push to release branches now returns False from
_should_run_all_tests_and_versions()unless other conditions (pyproject.toml changes, etc.) require full tests.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Haiku 4.5 following the guidelines