Skip to content

[AIRFLOW-6246] Add support None in mysql_to_gcs#6808

Merged
mik-laj merged 2 commits intoapache:masterfrom
stoynov96:master
Dec 16, 2019
Merged

[AIRFLOW-6246] Add support None in mysql_to_gcs#6808
mik-laj merged 2 commits intoapache:masterfrom
stoynov96:master

Conversation

@stoynov96
Copy link
Contributor

@stoynov96 stoynov96 commented Dec 13, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    test_convert_type_5

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@ashb
Copy link
Member

ashb commented Dec 13, 2019

Do you think you could add a unit test to cover this please?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c43a5ec). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6808   +/-   ##
=========================================
  Coverage          ?   84.23%           
=========================================
  Files             ?      676           
  Lines             ?    38312           
  Branches          ?        0           
=========================================
  Hits              ?    32274           
  Misses            ?     6038           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/operators/mysql_to_gcs.py 97.72% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c43a5ec...bad0b72. Read the comment docs.

@mik-laj mik-laj changed the title [AIRFLOW-6246] Bytes conversion when value is None now doesn't fail [AIRFLOW-6246] Add support None in mysql_to_gcs Dec 16, 2019
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Dec 16, 2019
@mik-laj mik-laj merged commit fd124a5 into apache:master Dec 16, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants