Skip to content

[AIRFLOW-XXX] Bump Jira version to fix issue with async#6813

Merged
potiuk merged 1 commit intoapache:masterfrom
kaxil:fix-jira
Dec 13, 2019
Merged

[AIRFLOW-XXX] Bump Jira version to fix issue with async#6813
potiuk merged 1 commit intoapache:masterfrom
kaxil:fix-jira

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Dec 13, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Because async is now a reserved keywor we need to bump JIRA version

Traceback (most recent call last):
  File "./dev/airflow-jira", line 25, in <module>
    import jira
  File "/Users/kaxilnaik/opt/anaconda3/lib/python3.7/site-packages/jira/__init__.py", line 10, in <module>
    from jira.client import Comment  # noqa: E402
  File "/Users/kaxilnaik/opt/anaconda3/lib/python3.7/site-packages/jira/client.py", line 337
    validate=False, get_server_info=True, async=False, logging=True, max_retries=3, proxies=None,
                                              ^
SyntaxError: invalid syntax

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    n/a

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested a review from ashb December 13, 2019 13:31
@potiuk potiuk merged commit b5d0b9d into apache:master Dec 13, 2019
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

@kaxil kaxil deleted the fix-jira branch January 5, 2020 03:57
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants