Skip to content

[AIRFLOW-6104] [AIP-21] Rename Datastore opertors#6853

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6104-Rename-datastore-service
Dec 19, 2019
Merged

[AIRFLOW-6104] [AIP-21] Rename Datastore opertors#6853
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6104-Rename-datastore-service

Conversation

@michalslowikowski00
Copy link
Contributor

Rename Datastore operators

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6104
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-6104-Rename-datastore-service branch from 7858d33 to 84bc431 Compare December 19, 2019 14:37
@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9b79c39). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6853   +/-   ##
=========================================
  Coverage          ?   84.27%           
=========================================
  Files             ?      680           
  Lines             ?    38451           
  Branches          ?        0           
=========================================
  Hits              ?    32406           
  Misses            ?     6045           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/gcp/operators/datastore.py 61.53% <100%> (ø)
...low/contrib/operators/datastore_export_operator.py 100% <100%> (ø)
airflow/gcp/example_dags/example_datastore.py 100% <100%> (ø)
...low/contrib/operators/datastore_import_operator.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b79c39...84bc431. Read the comment docs.

@potiuk potiuk merged commit 0c840d1 into apache:master Dec 19, 2019
KKcorps pushed a commit to KKcorps/airflow that referenced this pull request Dec 21, 2019
@michalslowikowski00 michalslowikowski00 deleted the AIRFLOW-6104-Rename-datastore-service branch January 26, 2020 08:35
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments