Skip to content

Comments

[AIRFLOW-6106] [AIP-21] Rename GCP compute operators#6872

Merged
turbaszek merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6106-Rename-compute-service
Dec 21, 2019
Merged

[AIRFLOW-6106] [AIP-21] Rename GCP compute operators#6872
turbaszek merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6106-Rename-compute-service

Conversation

@michalslowikowski00
Copy link
Contributor

@michalslowikowski00 michalslowikowski00 commented Dec 21, 2019

Rename GCP compute operators.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6106
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

fixed examp. dags, howto, tests

fixed docstrings
@codecov-io
Copy link

codecov-io commented Dec 21, 2019

Codecov Report

Merging #6872 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6872      +/-   ##
==========================================
- Coverage   84.57%   84.29%   -0.28%     
==========================================
  Files         680      680              
  Lines       38454    38478      +24     
==========================================
- Hits        32521    32434      -87     
- Misses       5933     6044     +111
Impacted Files Coverage Δ
airflow/contrib/operators/gcp_compute_operator.py 100% <100%> (ø) ⬆️
airflow/gcp/operators/compute.py 98.49% <100%> (ø) ⬆️
airflow/gcp/example_dags/example_compute.py 100% <100%> (ø) ⬆️
airflow/contrib/hooks/gcp_compute_hook.py 100% <100%> (ø) ⬆️
airflow/gcp/example_dags/example_compute_igm.py 100% <100%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ebe00...d95e23f. Read the comment docs.

@turbaszek turbaszek merged commit 3664060 into apache:master Dec 21, 2019
KKcorps pushed a commit to KKcorps/airflow that referenced this pull request Dec 21, 2019
fixed examp. dags, howto, tests

fixed docstrings
@michalslowikowski00 michalslowikowski00 deleted the AIRFLOW-6106-Rename-compute-service branch January 26, 2020 08:35
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
fixed examp. dags, howto, tests

fixed docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants