Only log task state cleanup for configured worker state store backends#68878
Merged
Conversation
jason810496
approved these changes
Jun 23, 2026
phanikumv
reviewed
Jun 23, 2026
Contributor
There was a problem hiding this comment.
Seeing a CI failure. Replace this line with the below code
with mock.patch(
"airflow.sdk.execution_time.context._get_worker_state_store_backend",return_value=mock_backend),
mock.patch("airflow.sdk.execution_time.task_runner._get_worker_state_store_backend", return_value=mock_backend
):
Lee-W
reviewed
Jun 23, 2026
Lee-W
left a comment
Member
There was a problem hiding this comment.
let's add a small unit test for it
Contributor
Author
|
@Lee-W @phanikumv handled your comments, ptal! |
Lee-W
approved these changes
Jun 23, 2026
phanikumv
approved these changes
Jun 23, 2026
vatsrahul1001
approved these changes
Jun 23, 2026
cetingokhan
pushed a commit
to cetingokhan/airflow
that referenced
this pull request
Jun 24, 2026
apache#68878) * Only log task state cleanup for configured worker state store backends * fixing CI and adding test for wei
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Noticed this while testing https://cwiki.apache.org/confluence/display/AIRFLOW/Test+cases+AIP103+Task+State+Management with beta1 for 3.3.0, we should only ever be logging
Clearing task state from custom backend as clear_on_success is enabled. The database references will be cleared by the API server.when a custom backend is configured AND not whenclear_on_successis set on a default backend which could be really confusing when debugging things.{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.