Skip to content

[AIRFLOW-6340] Make tests/contrib pylint compatible#6896

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6340-pylint-tests
Dec 25, 2019
Merged

[AIRFLOW-6340] Make tests/contrib pylint compatible#6896
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6340-pylint-tests

Conversation

@turbaszek
Copy link
Member

@turbaszek turbaszek commented Dec 25, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

Codecov Report

Merging #6896 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6896      +/-   ##
==========================================
- Coverage   84.62%   84.33%   -0.29%     
==========================================
  Files         679      679              
  Lines       38497    38497              
==========================================
- Hits        32578    32468     -110     
- Misses       5919     6029     +110
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0fbb52...4555cef. Read the comment docs.

@potiuk potiuk merged commit d5fa17f into apache:master Dec 25, 2019
@turbaszek turbaszek deleted the AIRFLOW-6340-pylint-tests branch December 26, 2019 23:24
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants