Skip to content

[AIRFLOW-6377] Decouple CLI utils from argparse.Namespace#6934

Closed
mik-laj wants to merge 1 commit into
apache:masterfrom
mik-laj:AIRFLOW-6377
Closed

[AIRFLOW-6377] Decouple CLI utils from argparse.Namespace#6934
mik-laj wants to merge 1 commit into
apache:masterfrom
mik-laj:AIRFLOW-6377

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Dec 27, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6377
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj changed the title [AIRFLOW-6377] Decouple cli utils from argparse.Namespace [AIRFLOW-6377] Decouple CLI utils from argparse.Namespace Dec 27, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 27, 2019

Codecov Report

Merging #6934 into master will decrease coverage by 0.28%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6934      +/-   ##
==========================================
- Coverage   84.71%   84.42%   -0.29%     
==========================================
  Files         679      679              
  Lines       38518    38521       +3     
==========================================
- Hits        32630    32522     -108     
- Misses       5888     5999     +111
Impacted Files Coverage Δ
airflow/cli/commands/dag_command.py 86.61% <100%> (ø) ⬆️
airflow/cli/commands/task_command.py 68.11% <71.42%> (ø) ⬆️
airflow/utils/cli.py 74.48% <92.3%> (-0.25%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/contrib/operators/ssh_operator.py 83.33% <0%> (-1.29%) ⬇️
airflow/jobs/backfill_job.py 91.88% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2028a93...9046829. Read the comment docs.

@mik-laj
Copy link
Copy Markdown
Member Author

mik-laj commented Dec 28, 2019

Merged: 4fd3b89

@mik-laj mik-laj closed this Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants