[AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…

[tooptoop4]

…ption

Make sure you have checked all steps below.

Jira

• My PR addresses the following AIRFLOW-6360 issues and references them in the PR title. For example, "[AIRFLOW-6360] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-6360
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-6360], code changes always need a Jira issue.
  • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

[codecov-io]

Codecov Report

Merging #6944 into master will decrease coverage by 0.01%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master    #6944      +/-   ##
==========================================
- Coverage    84.7%   84.69%   -0.02%     
==========================================
  Files         680      680              
  Lines       38556    38566      +10     
==========================================
+ Hits        32659    32662       +3     
- Misses       5897     5904       +7

Impacted Files	Coverage Δ
airflow/www/views.py	75.63% <62.5%> (-0.46%)	⬇️
airflow/utils/log/file_processor_handler.py	88% <0%> (+2.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d97d16...126977d. Read the comment docs.

[drsantos20]

Hi @tooptoop4 do we already have tests for these changes?

[tooptoop4]

@drsantos20 i couldn't see a test for original task_stats functionality, as this change is guarded by opt-in config then no impact for existing users

[potiuk]

@tooptoop4 -> Still the tests are targeting the "future" rather than the past.

We often cherry-pick some changes to 1.10 now + we want to make sure that we can refactor Airflow in the future without having to run tests manually, so we are now fairly strict in requiring tests for new functionalities - even if there were missing tests in the past. If you want to add new functionality, we expect you add tests, sorry :(.

[mik-laj]

Hi. Can you add some documentation? We do not yet have a document describing the configuration options of the webserver. Would you like to create it? If not, that's fine and you can also create a new document in the howto directory.

[tooptoop4]

see #7037

[tooptoop4]

superseded by #7037