Add log socket reconnections#69696
Open
guan404ming wants to merge 1 commit into
Open
Conversation
boring-cyborg
Bot
added
AIP-108: Coordinator
guan404ming
changed the title
guan404ming
force-pushed
the
logs-server-reaccept
branch
from
4372cc4 to
e55d9e7
Compare
1 task
A runtime that drops its logs connection could never reconnect, so any logs buffered during the outage were silently black-holed. The listener now keeps accepting, verifies the peer belongs to the child process tree, and tolerates transient socket errors without stalling or killing the supervisor monitor loop.
guan404ming
force-pushed
the
logs-server-reaccept
branch
from
e55d9e7 to
52e27b7
Compare
guan404ming
requested review from
amoghrajesh,
ashb,
jason810496,
kaxil and
uranusjr
as code owners
guan404ming
changed the title
jason810496
reviewed
Jul 11, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Another direction on this one. Do we really need to introduce the reconnecting for log socket at all?
I think it makes sense to introduce reconnecting/ retrying for those client-sever are on the different host machines.
Since the coordinator (Python task-SDK) and Lang-SDK (TS-SDK in this case) will always on the same worker and on the same host.
Would it be better to not reconnecting at all for both side, as the unexpected TCP connection close on Lang-SDK side means the serious errors from OS level (or SIGKILL etc) and remove the reconnecting part from TS-SDK (IIRC, Java and Go didn't implement the socket level reconnecting).
WDYT? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A task runtime that dropped its logs connection could never reconnect, so logs buffered during the outage were silently lost.
How
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines