[AIRFLOW-6402] SSH operator exception - NoneType object has no attribute startswith#6970
Closed
ohadmata wants to merge 3 commits intoapache:v1-10-stablefrom
ohadmata:v1-10-stable
Closed
[AIRFLOW-6402] SSH operator exception - NoneType object has no attribute startswith#6970ohadmata wants to merge 3 commits intoapache:v1-10-stablefrom ohadmata:v1-10-stable
ohadmata wants to merge 3 commits intoapache:v1-10-stablefrom
ohadmata:v1-10-stable
Conversation
…ibute 'startswith' fix exception
Codecov Report
@@ Coverage Diff @@
## v1-10-stable #6970 +/- ##
===============================================
- Coverage 81.5% 81.5% -0.01%
===============================================
Files 526 526
Lines 36032 36034 +2
===============================================
+ Hits 29368 29369 +1
- Misses 6664 6665 +1
Continue to review full report at Codecov.
|
potiuk
requested changes
Jan 2, 2020
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
I think there are more commits than needed here? Also It would be great if you follow our new beautiful shiny template we have when creating the PR.
| Propagate message removing escape codes. | ||
| """ | ||
| self.logger.log(self.level, remove_escape_codes(message)) | ||
| # self.logger.log(self.level, remove_escape_codes(message)) |
| if(auto_tailing && checkAutoTailingCondition()) { | ||
| var should_scroll = true | ||
| } | ||
|
|
Contributor
Author
|
I made a mistake here. sorry. will fix that in another pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AIRFLOW-6402] https://issues.apache.org/jira/browse/AIRFLOW-6402
fix exception