[AIRFLOW-6417] Disable approval requirements from mergeable#6990
Merged
[AIRFLOW-6417] Disable approval requirements from mergeable#6990
Conversation
Member
|
Agree. It's mostly annoying and does not add anything. |
potiuk
approved these changes
Jan 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #6990 +/- ##
==========================================
+ Coverage 84.84% 84.85% +<.01%
==========================================
Files 679 679
Lines 38536 38536
==========================================
+ Hits 32697 32698 +1
+ Misses 5839 5838 -1
Continue to review full report at Codecov.
|
kaxil
approved these changes
Jan 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I review PR that are in good condition in the first place - they have a green label next to the title. Unfortunately, now all PRs are always red before they are accepted. When accepted, they are often merged immediately, so all open PRs are always red. This useful indicator now makes no sense.
In my opinion, we do not have a problem with merging PRs that are not accepted, so this option does not solve any of our problems.
[AIRFLOW-6417]for document-only changesIn case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.