Skip to content

[AIRFLOW-6417] Disable approval requirements from mergeable#6990

Merged
kaxil merged 1 commit intomasterfrom
mik-laj-patch-1
Jan 1, 2020
Merged

[AIRFLOW-6417] Disable approval requirements from mergeable#6990
kaxil merged 1 commit intomasterfrom
mik-laj-patch-1

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Jan 1, 2020

I review PR that are in good condition in the first place - they have a green label next to the title. Unfortunately, now all PRs are always red before they are accepted. When accepted, they are often merged immediately, so all open PRs are always red. This useful indicator now makes no sense.

Screenshot 2020-01-01 at 12 32 07

In my opinion, we do not have a problem with merging PRs that are not accepted, so this option does not solve any of our problems.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk potiuk requested a review from kaxil January 1, 2020 12:36
@potiuk
Copy link
Member

potiuk commented Jan 1, 2020

Agree. It's mostly annoying and does not add anything.

@codecov-io
Copy link

codecov-io commented Jan 1, 2020

Codecov Report

Merging #6990 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6990      +/-   ##
==========================================
+ Coverage   84.84%   84.85%   +<.01%     
==========================================
  Files         679      679              
  Lines       38536    38536              
==========================================
+ Hits        32697    32698       +1     
+ Misses       5839     5838       -1
Impacted Files Coverage Δ
airflow/jobs/backfill_job.py 91.88% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baaf7ee...2357a3f. Read the comment docs.

@kaxil kaxil merged commit b76245e into master Jan 1, 2020
@kaxil kaxil deleted the mik-laj-patch-1 branch January 10, 2020 15:37
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments