Skip to content

[AIRFLOW-6487] Romove unnecessary for-loop#7079

Closed
Gabriel39 wants to merge 1 commit intoapache:masterfrom
Gabriel39:master
Closed

[AIRFLOW-6487] Romove unnecessary for-loop#7079
Gabriel39 wants to merge 1 commit intoapache:masterfrom
Gabriel39:master

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Jan 6, 2020


Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6487
Romove unnecessary for loop:

In DagFileProcessorManager, dag files are processed periodically. Processor manager will put dag into queue except file_paths_in_progress, file_paths_recently_processed and files_paths_at_run_limit. While min_file_process_interval = 0 in config by default, there is unnecessary for-loop when get file_paths_recently_processed.

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


@boring-cyborg
Copy link

boring-cyborg bot commented Jan 6, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)

In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

@Gabriel39 Gabriel39 changed the title AIRFLOW-6487: Romove unnecessary for-loop [AIRFLOW-6487] Romove unnecessary for-loop Jan 6, 2020
@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #7079 into master will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7079      +/-   ##
==========================================
- Coverage   85.07%   84.79%   -0.29%     
==========================================
  Files         680      680              
  Lines       38810    38812       +2     
==========================================
- Hits        33019    32909     -110     
- Misses       5791     5903     +112
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 87.66% <100%> (-0.34%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748e3c3...f46cc63. Read the comment docs.

@bolkedebruin
Copy link
Contributor

Can you ensure tests are provided?

@stale
Copy link

stale bot commented Feb 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 27, 2020
@stale stale bot closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants