Skip to content

[AIRFLOW-6488] Add missing relation to op4#7080

Merged
mik-laj merged 1 commit intoapache:masterfrom
loicbenoit:patch-2
Jan 6, 2020
Merged

[AIRFLOW-6488] Add missing relation to op4#7080
mik-laj merged 1 commit intoapache:masterfrom
loicbenoit:patch-2

Conversation

@loicbenoit
Copy link
Contributor

@loicbenoit loicbenoit commented Jan 6, 2020

Context: https://airflow.apache.org/docs/stable/concepts.html#concepts-operators, near line 401
In last "and equivalent to", it seems op4 should still depend on both op2 and op3.

op1 >> op2 >> op4
op1 >> op3 >> op4

and equivalent to:

op1.set_downstream([op2, op3])
op4.set_upstream([op2, op3]) #Expected this, but it's missing.


Issue link: AIRFLOW-6488

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

It seems op4 should depend on both op2 and op3.
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 6, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)

In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

@mik-laj mik-laj merged commit 033e863 into apache:master Jan 6, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 6, 2020

Awesome work, congrats on your first merged pull request!

galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants