Skip to content

Comments

[AIRFLOW-XXXX] Add useful tips to first PR msg#7082

Merged
kaxil merged 3 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-XXXX-add-info-to-first-pr-msg
Jan 6, 2020
Merged

[AIRFLOW-XXXX] Add useful tips to first PR msg#7082
kaxil merged 3 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-XXXX-add-info-to-first-pr-msg

Conversation

@turbaszek
Copy link
Member

@turbaszek turbaszek commented Jan 6, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)

Here are some useful points:

  • Check the quality of your code (flake8, pylint and type annotations). Our pre-commits
    will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory).
    Adding a new operator? Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from
    Committers.

Apache Airflow is a community-driven project and together we are making it better 🚀

In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/


Issue link: Document only change, no JIRA issue

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@turbaszek turbaszek requested review from kaxil and potiuk January 6, 2020 17:37
@kaxil kaxil requested a review from dimberman January 6, 2020 17:40
@turbaszek turbaszek requested a review from kaxil January 6, 2020 17:53
@turbaszek turbaszek requested a review from potiuk January 6, 2020 18:05
@kaxil
Copy link
Member

kaxil commented Jan 6, 2020

Mergeable is failing: https://github.com/apache/airflow/pull/7082/checks?check_run_id=376054901 ;)

@kaxil kaxil merged commit 64204d3 into apache:master Jan 6, 2020
@kaxil
Copy link
Member

kaxil commented Jan 6, 2020

Looks good, thanks @nuclearpinguin

galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@turbaszek turbaszek deleted the AIRFLOW-XXXX-add-info-to-first-pr-msg branch March 14, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants