Skip to content

Comments

[AIRFLOW-6510] - Fix Druid operator rendering from file#7102

Closed
alexnu wants to merge 5 commits intoapache:masterfrom
alexnu:fix-druid-operator
Closed

[AIRFLOW-6510] - Fix Druid operator rendering from file#7102
alexnu wants to merge 5 commits intoapache:masterfrom
alexnu:fix-druid-operator

Conversation

@alexnu
Copy link
Contributor

@alexnu alexnu commented Jan 8, 2020

Dear maintainers,

Please accept my PR which fixes the way druid specification json is loaded by leveraging template fields as in most other operators, rather that manually parsing the file in the operator.

Fixed existing tests and deleted one unneeded test case, as the operator is no longer opening a file.


Issue link: AIRFLOW-6510

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 8, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)

Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits
    will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory).
    Adding a new operator? Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing
    locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from
    Committers.

Apache Airflow is a community-driven project and together we are making it better 🚀.

In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

@alexnu alexnu force-pushed the fix-druid-operator branch from 26fc25c to 17e0197 Compare January 9, 2020 15:04
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2754427). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7102   +/-   ##
=========================================
  Coverage          ?   84.95%           
=========================================
  Files             ?      682           
  Lines             ?    39043           
  Branches          ?        0           
=========================================
  Hits              ?    33168           
  Misses            ?     5875           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/contrib/operators/druid_operator.py 82.35% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2754427...17e0197. Read the comment docs.

@alexnu alexnu closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants