[AIRFLOW-6545] Add commit message validation #7149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
AIRFLOW-6545-validate-all-commit-messages
branch
from
bebe2f5 to
1919cb9
Compare
potiuk
changed the title
turbaszek
approved these changes
Jan 13, 2020
turbaszek
reviewed
Jan 13, 2020
Member
Author
|
Hey @kaxil - do not merge it yet as I want to make some small update after talking to @nuclearpinguin and @mik-laj |
potiuk
changed the title
potiuk
force-pushed
the
AIRFLOW-6545-validate-all-commit-messages
branch
from
76eb751 to
74dffcb
Compare
potiuk
changed the title
Member
Author
|
OK. Ready to merge. I improved the kaxil/boring-cyborg#2 to better handle multiple/single commit cases and updated regexps :) |
kaxil
approved these changes
Jan 13, 2020
Member
|
Awesome, @potiuk |
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation of AIRFLOW* jira issue id to all commits.
Note that it requires kaxil/boring-cyborg#2 to be merged in @kaxil 's boring-cyborg and it requires to grant new permissions to the boring-cyborg:
Commit status: read&write.Issue link: AIRFLOW-6545
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.