[AIRFLOW-6102] [AIP-21] Rename Dataproc operators#7151
Merged
turbaszek merged 1 commit intoapache:masterfrom Jan 13, 2020
Merged
[AIRFLOW-6102] [AIP-21] Rename Dataproc operators#7151turbaszek merged 1 commit intoapache:masterfrom
turbaszek merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7151 +/- ##
==========================================
- Coverage 85.28% 85.03% -0.25%
==========================================
Files 707 707
Lines 39255 39347 +92
==========================================
- Hits 33478 33459 -19
- Misses 5777 5888 +111
Continue to review full report at Codecov.
|
turbaszek
reviewed
Jan 13, 2020
| |airflow.contrib.operators.dataproc_operator.DataProcPigOperator |airflow.gcp.operators.dataproc.DataprocSubmitPigJobOperator | | ||
| |airflow.contrib.operators.dataproc_operator.DataProcPySparkOperator |airflow.gcp.operators.dataproc.DataprocSubmitPySparkJobOperator | | ||
| |airflow.contrib.operators.dataproc_operator.DataProcSparkOperator |airflow.gcp.operators.dataproc.DataprocSubmitSparkJobOperator | | ||
| |airflow.contrib.operators.dataproc_operator.DataProcSparkSqlOperator |airflow.gcp.operators.dataproc.DataprocSubmitSparkSqlJobOperator | |
Member
There was a problem hiding this comment.
I think there's no need to change names in SubmitXJob operators because those are deperecated anyway by DataprocSubmitJobOperator. WDYT @mik-laj ?
Member
There was a problem hiding this comment.
This may not be needed, but it is already done and standardizes our code. In my opinion, this is a positive change. We don't need to revert it. Let's go with it.
turbaszek
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR contains changes regarding AIP-21 (renaming GCP operators and hooks):
Issue link: AIRFLOW-6102
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.