Skip to content

[AIRFLOW-6603] Remove unnecessary pylint warnings#7224

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6603-remove-unnecessary-pylint-warnings
Jan 21, 2020
Merged

[AIRFLOW-6603] Remove unnecessary pylint warnings#7224
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6603-remove-unnecessary-pylint-warnings

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 21, 2020

There are unnecessary pylint warnings in ODBC that are
spamming the error messages. We need to silence the.


Issue link: AIRFLOW-6603

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

There are unnecessary pylint warnings in ODBC that are
spamming the error messages. We need to silence the.
@potiuk potiuk requested review from kaxil, mik-laj and turbaszek January 21, 2020 01:46
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #7224 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #7224     +/-   ##
=========================================
- Coverage   85.53%   85.23%   -0.3%     
=========================================
  Files         756      758      +2     
  Lines       39859    39932     +73     
=========================================
- Hits        34094    34038     -56     
- Misses       5765     5894    +129
Impacted Files Coverage Δ
airflow/providers/odbc/hooks/odbc.py 92.22% <ø> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 76.47% <0%> (-21.18%) ⬇️
airflow/api/client/local_client.py 92% <0%> (-8%) ⬇️
airflow/api/client/api_client.py 63.15% <0%> (-1.55%) ⬇️
airflow/lineage/__init__.py 93.84% <0%> (ø) ⬆️
airflow/api/client/json_client.py 0% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b44c0f...933319f. Read the comment docs.

@potiuk potiuk merged commit 2b06d0a into apache:master Jan 21, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
There are unnecessary pylint warnings in ODBC that are
spamming the error messages. We need to silence the.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments