fixed Variable json deserialization #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sv3ndk
commented
Dec 3, 2015
sv3ndk
commented
- in case value is missing, previous behaviour was trying to deserialize the default value from json
- added a convenience setter: Variable.set(key, value)
- fixes Variables.get tries to json-deserialize the default value #701
- 2 new UTs
- in case value is missing, previous behaviour was trying to deserialize the default value from json - added a convenience setter: Variable.set(key, value) - cf apache#701 - 2 new UTs
Member
|
|
mistercrunch
added a commit
that referenced
this pull request
Dec 3, 2015
fixed Variable json deserialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.