Skip to content

[AIRFLOW-6689] Last changes for AIP-21#7301

Merged
mik-laj merged 13 commits intoapache:masterfrom
PolideaInternal:AIFLOW-6680
Feb 2, 2020
Merged

[AIRFLOW-6689] Last changes for AIP-21#7301
mik-laj merged 13 commits intoapache:masterfrom
PolideaInternal:AIFLOW-6680

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Jan 30, 2020

I propose following changes:

Move TestHiveCli to hooks.test_hive
Improve structure of Cassandra senssor testss
Move Cassandra hook tests to test_cassandra
Move operators.presto_to_mysql operators.mysql.operators.presto_to_mysql
Remove duplicate test_to_gcs_to_s3
Move MSSQL tests to providers.microsoft.mssql.operators
Move GenericTransfer tests to test_generic_transfer
Move PythonVirtualenvOperator to test_python
Move GCP system tests to providers.google.cloud
Move myqsl_to_hive tests from test_operators
Move myqsl tests from test_operators to test_mysql
Move myqsl tests from test_operators to test_mysql
Move postgres tests from test_operators to test_postgres

Issue link: AIRFLOW-6689

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:dev-tools area:docs provider:google Google (including GCP) related issues labels Jan 30, 2020
@mik-laj mik-laj changed the title [AIFLOW-6680] Last changes for AIP-21 [AIRFLOW-6680] Last changes for AIP-21 Jan 30, 2020
@mik-laj mik-laj force-pushed the AIFLOW-6680 branch 3 times, most recently from 8cef9fd to a91b612 Compare January 31, 2020 20:50
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Feb 2, 2020

Please rebase to latest master @mik-laj - we had a failing master drama and there is much higher chance the build will succeed. We have still some intermittent errors, but there should be less often.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 2, 2020

Codecov Report

Merging #7301 into master will increase coverage by 53.79%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #7301       +/-   ##
==========================================
+ Coverage    32.4%   86.2%   +53.79%     
==========================================
  Files         866     867        +1     
  Lines       40556   40559        +3     
==========================================
+ Hits        13144   34963    +21819     
+ Misses      27412    5596    -21816
Impacted Files Coverage Δ
airflow/operators/presto_to_mysql.py 100% <100%> (+57.14%) ⬆️
...rflow/providers/mysql/operators/presto_to_mysql.py 100% <100%> (ø)
...irflow/providers/apache/cassandra/sensors/table.py 0% <0%> (-62.5%) ⬇️
...rflow/providers/apache/cassandra/sensors/record.py 0% <0%> (-58.83%) ⬇️
airflow/plugins_manager.py 86.98% <0%> (-1.45%) ⬇️
airflow/executors/executor_loader.py 78.94% <0%> (ø) ⬆️
airflow/bin/airflow 84.61% <0%> (ø) ⬆️
airflow/bin/cli.py 94.73% <0%> (+2.1%) ⬆️
airflow/kubernetes/pod_launcher.py 91.97% <0%> (+2.91%) ⬆️
... and 734 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94639f...68d7bef. Read the comment docs.

@mik-laj mik-laj merged commit 1e576f1 into apache:master Feb 2, 2020
@mik-laj mik-laj changed the title [AIRFLOW-6680] Last changes for AIP-21 [AIRFLOW-6689] Last changes for AIP-21 Feb 2, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
* Move postgres tests from test_operators to test_postgres

* Move myqsl tests from test_operators to test_mysql

* Move myqsl tests from test_operators to test_mysql

* Move myqsl_to_hive tests from test_operators

* Move GCP system tests to providers.google.cloud

* Move PythonVirtualenvOperator to test_python

* Move GenericTransfer tests to test_generic_transfer

* Move MSSQL tests to providers.microsoft.mssql.operators

* Remove duplicate test_to_gcs_to_s3

* [AIP-21] Move operators.presto_to_mysql operators.mysql.operators.presto_to_mysql

* Move Cassandra hook tests to test_cassandra

* Improve strcutre of cassandra senssor testss

* Move TestHiveCli to hooks.test_hive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants