Skip to content

[AIRFLOW-6691] Add tests that protect the deprecated packages#7303

Merged
mik-laj merged 3 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-6691
Feb 3, 2020
Merged

[AIRFLOW-6691] Add tests that protect the deprecated packages#7303
mik-laj merged 3 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-6691

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Jan 31, 2020

Some people may mistakenly add new changes to a package that is depreccated. We should detect this to avoid confusion and notify the contributor.


Issue link: AIRFLOW-6691

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:dev-tools area:docs provider:google Google (including GCP) related issues labels Jan 31, 2020
@mik-laj mik-laj changed the title [AIRFLOW-6691][depends on AIFLOW-6680] Add tests that protect the deprecated packages [AIRFLOW-6691] Add tests that protect the deprecated packages Feb 2, 2020
@mik-laj mik-laj requested a review from potiuk February 2, 2020 20:53
Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one spelling mistake

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Feb 2, 2020

Static check failures :(

@mik-laj
Copy link
Copy Markdown
Member Author

mik-laj commented Feb 2, 2020

It's is unrelated changes. #7309 (comment)

@mik-laj
Copy link
Copy Markdown
Member Author

mik-laj commented Feb 2, 2020

Awesome @coopergillan is already working on it.

Kamil Breguła and others added 2 commits February 2, 2020 23:21
@mik-laj mik-laj merged commit d9fc5be into apache:master Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants