[AIRFLOW-6725] Simplify chaining operation in DagFileProcessorManager#7349
Merged
[AIRFLOW-6725] Simplify chaining operation in DagFileProcessorManager#7349
Conversation
turbaszek
approved these changes
Feb 3, 2020
mik-laj
approved these changes
Feb 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #7349 +/- ##
===========================================
- Coverage 86.35% 32.09% -54.27%
===========================================
Files 871 870 -1
Lines 40613 40600 -13
===========================================
- Hits 35073 13030 -22043
- Misses 5540 27570 +22030
Continue to review full report at Codecov.
|
Member
Author
chained-comparison - This pylint rule should, in theory, take care of this.(pylint-dev/pylint#2046) Need to dig in more detail on why it didn't check this, maybe the file is still not pylint compatible and hence in ignored! list |
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify chaining operation in an IF condition
Issue link: AIRFLOW-6725
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.