Skip to content

[AIRFLOW-6781] Enforce example_dags and guide for Google integrations#7404

Merged
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6781-enforce-docs-dags
Feb 13, 2020
Merged

[AIRFLOW-6781] Enforce example_dags and guide for Google integrations#7404
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6781-enforce-docs-dags

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Feb 12, 2020

Hello,

For operators from the Google package we have examples of DAGs and guides for the majority of integrations. Ther existence is already common, so we can enforce this rule for future integrations also.

Best regards,


Issue link: AIRFLOW-6781

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Feb 12, 2020
@mik-laj mik-laj force-pushed the AIRFLOW-6781-enforce-docs-dags branch from 45a1788 to 23d2efe Compare February 12, 2020 12:06
@codecov-io
Copy link

Codecov Report

Merging #7404 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7404      +/-   ##
==========================================
- Coverage   86.61%   86.33%   -0.28%     
==========================================
  Files         873      874       +1     
  Lines       40757    40868     +111     
==========================================
- Hits        35300    35284      -16     
- Misses       5457     5584     +127
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0%> (-45.08%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.38% <0%> (-25.52%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
airflow/config_templates/airflow_local_settings.py 65.38% <0%> (-6.36%) ⬇️
airflow/utils/log/stackdriver_task_handler.py 97.14% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967930c...23d2efe. Read the comment docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MISSING_EXAMPLED_DAG = {
MISSING_EXAMPLE_DAG = {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@mik-laj mik-laj force-pushed the AIRFLOW-6781-enforce-docs-dags branch from 23d2efe to ac5956e Compare February 12, 2020 15:37
@mik-laj mik-laj merged commit 33af616 into apache:master Feb 13, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants