Skip to content

[AIRFLOW-XXXX] Fix typo in example_bigquery DAG#7429

Merged
mik-laj merged 1 commit intoapache:masterfrom
ryanyuan:bigquery-example-dag-typo
Feb 17, 2020
Merged

[AIRFLOW-XXXX] Fix typo in example_bigquery DAG#7429
mik-laj merged 1 commit intoapache:masterfrom
ryanyuan:bigquery-example-dag-typo

Conversation

@ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Feb 16, 2020

Fix typo in example_bigquery DAG. Task id in xcom_pull should match the real task id, which is "get_data".


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

[AIRFLOW-XXXX] Typo in example_bigquery DAG
@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Feb 16, 2020
@ryanyuan
Copy link
Contributor Author

@mik-laj PTAL

@ryanyuan ryanyuan requested a review from mik-laj February 16, 2020 10:09
@codecov-io
Copy link

Codecov Report

Merging #7429 into master will increase coverage by 52.87%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7429       +/-   ##
===========================================
+ Coverage   32.91%   85.79%   +52.87%     
===========================================
  Files         877      878        +1     
  Lines       41150    41505      +355     
===========================================
+ Hits        13545    35608    +22063     
+ Misses      27605     5897    -21708
Impacted Files Coverage Δ
...ders/google/cloud/example_dags/example_bigquery.py 100% <ø> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0%> (-39.44%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.38% <0%> (-25.52%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
airflow/bin/airflow 84.61% <0%> (ø)
airflow/plugins_manager.py 86.95% <0%> (+0.72%) ⬆️
airflow/executors/celery_executor.py 88.51% <0%> (+3.37%) ⬆️
... and 749 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb30ed...6311415. Read the comment docs.

@mik-laj mik-laj merged commit 5b199cb into apache:master Feb 17, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
[AIRFLOW-XXXX] Typo in example_bigquery DAG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants