Skip to content

[AIRFLOW-6821] - Success callback not called when task marked as success from UI#7438

Closed
saurabhdhupar wants to merge 5 commits intoapache:masterfrom
saurabhdhupar:master
Closed

[AIRFLOW-6821] - Success callback not called when task marked as success from UI#7438
saurabhdhupar wants to merge 5 commits intoapache:masterfrom
saurabhdhupar:master

Conversation

@saurabhdhupar
Copy link
Contributor

@saurabhdhupar saurabhdhupar commented Feb 17, 2020


Issue link: AIRFLOW-6821

Make sure to mark the boxes below before creating PR: [x]

  • [ x] Description above provides context of the change
  • [x ] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • [ x] Unit tests coverage for changes (not needed for documentation changes)
  • [ x] Commits follow "How to write a good git commit message"
  • [ x] Relevant documentation is updated including usage instructions.
  • [ x] I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Feb 17, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 17, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@saurabhdhupar saurabhdhupar changed the title [AIRFLOW-6821] - Success callback when task marked as success from UI [AIRFLOW-6821] - Success callback not called when task marked as success from UI Feb 17, 2020
@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #7438 into master will increase coverage by 53.41%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7438       +/-   ##
===========================================
+ Coverage   32.95%   86.37%   +53.41%     
===========================================
  Files         878      878               
  Lines       41219    41222        +3     
===========================================
+ Hits        13584    35604    +22020     
+ Misses      27635     5618    -22017
Impacted Files Coverage Δ
airflow/jobs/local_task_job.py 90.12% <100%> (+67.04%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0%> (-39.44%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.38% <0%> (-25.52%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
airflow/bin/airflow 84.61% <0%> (ø) ⬆️
airflow/plugins_manager.py 86.95% <0%> (+0.72%) ⬆️
airflow/bin/cli.py 94.73% <0%> (+2.1%) ⬆️
airflow/executors/celery_executor.py 88.51% <0%> (+3.37%) ⬆️
... and 749 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83ce26...7a780ba. Read the comment docs.

@saurabhdhupar saurabhdhupar requested a review from potiuk February 17, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants