[AIRFLOW-XXXX] clarify dag_id parameter#7463
Merged
kaxil merged 1 commit intoapache:masterfrom Feb 22, 2020
Merged
Conversation
Member
|
@MichaelChirico Not only your PR title, but also your git commit message. |
MichaelChirico
force-pushed
the
dag-id-doc
branch
from
51be51f to
c04feb5
Compare
I spent a while chasing this just now, wondering whether `:` is valid before finding `validate_key()` in helpers. I think it's helpful to surface this here directly.
MichaelChirico
force-pushed
the
dag-id-doc
branch
from
c04feb5 to
da7b001
Compare
Contributor
Author
|
failure seems unrelated:
|
kaxil
approved these changes
Feb 22, 2020
|
Awesome work, congrats on your first merged pull request! |
Member
|
Thanks @MichaelChirico 🎉 |
Contributor
Author
|
Of course now that it's merged I just noticed that |
Member
I missed it as well :) Want to submit another PR fixing it? |
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
I spent a while chasing this just now, wondering whether `:` is valid before finding `validate_key()` in helpers. I think it's helpful to surface this here directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AIRFLOW-XXXX]
Re-filing #7462 here:
I spent a while chasing this just now, wondering whether
:is valid before findingvalidate_key()in helpers.I think it's helpful to surface this here directly.
Trivial change so eschewing the other formality required in the PR template