Skip to content

[AIRFLOW-XXXX] Remove unused local variable value#7496

Merged
potiuk merged 1 commit intoapache:masterfrom
kaxil:unused-local-var
Feb 22, 2020
Merged

[AIRFLOW-XXXX] Remove unused local variable value#7496
potiuk merged 1 commit intoapache:masterfrom
kaxil:unused-local-var

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Feb 22, 2020

tags = [] is unused as tag is defined again 2 lines down


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from dimberman February 22, 2020 00:15
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Feb 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #7496 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7496      +/-   ##
==========================================
+ Coverage    86.5%   86.62%   +0.11%     
==========================================
  Files         887      887              
  Lines       41976    41975       -1     
==========================================
+ Hits        36312    36360      +48     
+ Misses       5664     5615      -49
Impacted Files Coverage Δ
airflow/www/views.py 76.35% <ø> (+0.11%) ⬆️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0%> (-64.16%) ⬇️
airflow/security/kerberos.py 30.43% <0%> (-45.66%) ⬇️
airflow/providers/mysql/operators/mysql.py 55% <0%> (-45%) ⬇️
airflow/providers/apache/hive/hooks/hive.py 76.02% <0%> (-1.54%) ⬇️
airflow/hooks/dbapi_hook.py 90.9% <0%> (-0.83%) ⬇️
airflow/jobs/backfill_job.py 91.83% <0%> (-0.29%) ⬇️
airflow/jobs/scheduler_job.py 90.09% <0%> (-0.15%) ⬇️
airflow/models/dag.py 91.29% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12001a...9d01e23. Read the comment docs.

@potiuk potiuk merged commit 9f73d90 into apache:master Feb 22, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@kaxil kaxil deleted the unused-local-var branch March 12, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants