[AIRFLOW-6874] Reap cgroup procs when terminate in cgroup taskrunner#7498
Closed
YingboWang wants to merge 1 commit intoapache:masterfrom
Closed
[AIRFLOW-6874] Reap cgroup procs when terminate in cgroup taskrunner#7498YingboWang wants to merge 1 commit intoapache:masterfrom
YingboWang wants to merge 1 commit intoapache:masterfrom
Conversation
KevinYang21
reviewed
Mar 11, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6874
Make sure to mark the boxes below before creating PR: [x]
Many airflow tasks create subprocesses and these subprocesses may create more subprocesses. In our experience, there is a risk that although a task failed and tried to reap the process group, there are still left over processes running and cause issues with both resources and correctness.
Propose to improve the cgroup task runner to reap all processes for current node on node termination.
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.