Skip to content

[AIRFLOW-6933] Pass in env vars for all operators#7576

Merged
saguziel merged 1 commit intoapache:masterfrom
saguziel:aguziel-2020-02-env-var-apache
Feb 28, 2020
Merged

[AIRFLOW-6933] Pass in env vars for all operators#7576
saguziel merged 1 commit intoapache:masterfrom
saguziel:aguziel-2020-02-env-var-apache

Conversation

@saguziel
Copy link
Contributor

@saguziel saguziel commented Feb 27, 2020

Pass in the airflow context env vars for all operators by doing it in ti._run_raw. Remove it from PythonOperator since it is unnecessary. Leave it in other places since they do special insertions.

Issue link: AIRFLOW-6933

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@saguziel saguziel force-pushed the aguziel-2020-02-env-var-apache branch from 0061ec6 to c341b7d Compare February 28, 2020 19:56
@codecov-io
Copy link

Codecov Report

Merging #7576 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7576      +/-   ##
==========================================
+ Coverage   86.56%   86.57%   +0.01%     
==========================================
  Files         896      896              
  Lines       42622    42626       +4     
==========================================
+ Hits        36896    36905       +9     
+ Misses       5726     5721       -5
Impacted Files Coverage Δ
airflow/operators/python.py 95% <ø> (-0.14%) ⬇️
airflow/models/taskinstance.py 95.33% <100%> (+0.15%) ⬆️
airflow/jobs/scheduler_job.py 90.46% <0%> (-0.03%) ⬇️
airflow/cli/commands/version_command.py 100% <0%> (ø) ⬆️
airflow/utils/dag_processing.py 86.65% <0%> (+0.05%) ⬆️
...rflow/providers/apache/spark/hooks/spark_submit.py 84.67% <0%> (+0.05%) ⬆️
airflow/models/dag.py 91.57% <0%> (+0.06%) ⬆️
airflow/jobs/backfill_job.py 92.15% <0%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d031f84...c341b7d. Read the comment docs.

@saguziel saguziel merged commit e63e811 into apache:master Feb 28, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants