Skip to content

Comments

[AIRFLOW-6969] Move backport build to test#7603

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6969-move-backport-build-to-test
Mar 1, 2020
Merged

[AIRFLOW-6969] Move backport build to test#7603
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6969-move-backport-build-to-test

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Mar 1, 2020

When one of the test builds fails even restarting it does not help to succeed
the whole job if there is "post-test" stage. The post-test job will remain in
cancelled state after the job is restarted

We should move prepare-backport-packages to test phase (it is very fast).


Issue link: WILL BE INSERTED BY boring-cyborg

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

When one of the test builds fails even restarting it does not help to succeed
the whole job if there is "post-test" stage. The post-test job will remain in
cancelled state after the job is restarted

We should move prepare-backport-packages to test phase (it is very fast).
@potiuk potiuk requested a review from mik-laj March 1, 2020 21:41
@mik-laj
Copy link
Member

mik-laj commented Mar 1, 2020

I'm not sure. Maybe we should run it only on master or manually?

@potiuk
Copy link
Member Author

potiuk commented Mar 1, 2020

I prefer to run everything, always. This way you find problems immediately when they appear and not after they are merged. I want this to be checked the same way as we check if all tests are running. And it is many times faster than the tests..

@potiuk potiuk merged commit 1d16de7 into apache:master Mar 1, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
When one of the test builds fails even restarting it does not help to succeed
the whole job if there is "post-test" stage. The post-test job will remain in
cancelled state after the job is restarted

We should move prepare-backport-packages to test phase (it is very fast).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants