Skip to content

[AIRFLOW-7055] Verbose logging option for google provider#7711

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-7055-verbose-logging-option-for-gcp
Mar 14, 2020
Merged

[AIRFLOW-7055] Verbose logging option for google provider#7711
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-7055-verbose-logging-option-for-gcp

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Mar 13, 2020


Issue link: AIRFLOW-7055

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk potiuk requested review from mik-laj and turbaszek March 13, 2020 07:44
Copy link
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea but should we move it to airflow.providers.google.__init__.py?

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can we move it to airflow.providers.google.__init__.py please?

@potiuk potiuk force-pushed the AIRFLOW-7055-verbose-logging-option-for-gcp branch from c8cba11 to d76bd1a Compare March 13, 2020 12:16
@potiuk
Copy link
Member Author

potiuk commented Mar 13, 2020

I think I got it correctly now :)

@potiuk
Copy link
Member Author

potiuk commented Mar 13, 2020

And we have more and more provider-specific stuff in providers, which is a good sign for AIP-8

@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #7711 into master will decrease coverage by 0.51%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7711      +/-   ##
==========================================
- Coverage   86.93%   86.42%   -0.52%     
==========================================
  Files         910      911       +1     
  Lines       44073    44084      +11     
==========================================
- Hits        38316    38099     -217     
- Misses       5757     5985     +228     
Impacted Files Coverage Δ
airflow/providers/google/__init__.py 36.36% <36.36%> (ø)
...flow/providers/apache/cassandra/hooks/cassandra.py 21.51% <0.00%> (-72.16%) ⬇️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0.00%> (-64.16%) ⬇️
airflow/providers/postgres/operators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0.00%> (-46.67%) ⬇️
airflow/providers/mysql/operators/mysql.py 55.00% <0.00%> (-45.00%) ⬇️
airflow/providers/redis/sensors/redis_key.py 61.53% <0.00%> (-38.47%) ⬇️
airflow/executors/celery_executor.py 50.67% <0.00%> (-37.84%) ⬇️
...roviders/google/cloud/operators/postgres_to_gcs.py 52.94% <0.00%> (-32.36%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e15236...73d0c05. Read the comment docs.

@potiuk
Copy link
Member Author

potiuk commented Mar 13, 2020

All good now. It works like a charm @mik-laj @kaxil -> (thanks @mik-laj for the "email version" of it ).

Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename "a" variable. Otherwise LGTM

@potiuk potiuk force-pushed the AIRFLOW-7055-verbose-logging-option-for-gcp branch from d76bd1a to 9737a99 Compare March 13, 2020 17:07
@potiuk potiuk force-pushed the AIRFLOW-7055-verbose-logging-option-for-gcp branch from 9737a99 to 73d0c05 Compare March 13, 2020 18:11
@potiuk potiuk merged commit 2bc020c into apache:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants