[AIRFLOW-7055] Verbose logging option for google provider#7711
Merged
potiuk merged 1 commit intoapache:masterfrom Mar 14, 2020
Merged
Conversation
turbaszek
reviewed
Mar 13, 2020
Member
turbaszek
left a comment
There was a problem hiding this comment.
I like the idea but should we move it to airflow.providers.google.__init__.py?
kaxil
reviewed
Mar 13, 2020
Member
kaxil
left a comment
There was a problem hiding this comment.
Yes, can we move it to airflow.providers.google.__init__.py please?
kaxil
reviewed
Mar 13, 2020
kaxil
reviewed
Mar 13, 2020
c8cba11 to
d76bd1a
Compare
Member
Author
|
I think I got it correctly now :) |
Member
Author
|
And we have more and more provider-specific stuff in providers, which is a good sign for AIP-8 |
Codecov Report
@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 86.93% 86.42% -0.52%
==========================================
Files 910 911 +1
Lines 44073 44084 +11
==========================================
- Hits 38316 38099 -217
- Misses 5757 5985 +228
Continue to review full report at Codecov.
|
Member
Author
mik-laj
approved these changes
Mar 13, 2020
Member
mik-laj
left a comment
There was a problem hiding this comment.
Please rename "a" variable. Otherwise LGTM
mik-laj
reviewed
Mar 13, 2020
d76bd1a to
9737a99
Compare
9737a99 to
73d0c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-7055
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.